Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase to kube 1.11 GA #20164

Merged
merged 5 commits into from
Jul 2, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 29, 2018

Creepy. no changes.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 29, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jun 29, 2018

@liggitt pkg/api tests look suspicious since we went to jsoniter

@deads2k
Copy link
Contributor Author

deads2k commented Jun 29, 2018

/test cmd

@deads2k
Copy link
Contributor Author

deads2k commented Jun 29, 2018

note to self, test-integration is probably failing on the both namespaced and not removal. Try to push through instead of repicking.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 29, 2018

another note to self, default GC quota list

@liggitt
Copy link
Contributor

liggitt commented Jun 30, 2018

@liggitt pkg/api tests look suspicious since we went to jsoniter

hmm, yes, those are exactly the things ugorji let in before that bit us when we tried to drop it. I had forgotten, but past me was mean enough to add tests to not let me forget. This requires more thought on what the best path out of this mess is.

xref https://bugzilla.redhat.com/show_bug.cgi?id=1525162
xref https://bugzilla.redhat.com/show_bug.cgi?id=1525224

@deads2k
Copy link
Contributor Author

deads2k commented Jul 2, 2018

verify Container test exited with code 2, reason OOMKilled

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jul 2, 2018

/test verify

@deads2k deads2k force-pushed the rebase-13-re-rebase branch 2 times, most recently from 4abd6d8 to 95a270e Compare July 2, 2018 17:27
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jul 2, 2018

Only change is Jordan's. Tagging

@openshift-merge-robot openshift-merge-robot merged commit 72ee68b into openshift:master Jul 2, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jul 3, 2018

@smarterclayton I've got one more critical backwards compatibility fix that I'll finish tomorrow and you'll be good to upgrade

@deads2k deads2k deleted the rebase-13-re-rebase branch July 3, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants