be tolerant on deployment decode and strict on encode #20185
Conversation
openshift-ci-robot
added
approved
|
@smarterclayton this is the one you need before you upgrade. |
|
/retest |
|
/retest |
pkg/apps/util/scheme.go
Outdated
| func init() { | ||
| utilruntime.Must(corev1.AddToScheme(annotationDecodingScheme)) | ||
| utilruntime.Must(appsv1.AddToScheme(annotationDecodingScheme)) | ||
| utilruntime.Must(appsv1helpers.AddToScheme(annotationDecodingScheme)) |
There was a problem hiding this comment.
move internal stuff into the TODO block to remove when internal versions go away
pkg/apps/util/scheme.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| utilruntime.Must(corev1.AddToScheme(annotationDecodingScheme)) |
There was a problem hiding this comment.
TODO to move explicit corev1 additions into appsv1.AddToScheme, etc
|
/lgtm |
|
@deads2k: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Allows us to consume legacy v1 serialized deploymentconfigs from annotations, but we only serialize into groupified.
@liggitt resolves rebase problem