Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 65549: Fix flexvolume in containerized kubelets #20358

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jul 18, 2018

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2018
@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2018
@liggitt
Copy link
Contributor

liggitt commented Jul 23, 2018

/hold
for 1.11.1 rebase

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
@gnufied
Copy link
Member Author

gnufied commented Jul 27, 2018

@liggitt does the hold still applies?

@liggitt
Copy link
Contributor

liggitt commented Jul 27, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2018
@smarterclayton
Copy link
Contributor

/refresh

@smarterclayton
Copy link
Contributor

/test gcp-crio

@fabianvf
Copy link
Member

fabianvf commented Aug 8, 2018

@jsafrane, @liggitt @smarterclayton looks like it needs the approved label as well, I think /approve does it

@fabianvf
Copy link
Member

fabianvf commented Aug 9, 2018

also, can this be backported to origin 3.10?

@liggitt
Copy link
Contributor

liggitt commented Aug 9, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018
@gnufied
Copy link
Member Author

gnufied commented Aug 13, 2018

The failure looks unrelated.

/test gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/storage size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants