switch remaining API groups to new scheme install #20372
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XXL
|
well, that ended up a little bit larger than intended. |
|
/retest |
| ) | ||
|
|
||
| const ( | ||
| GroupName = "build.openshift.io" | ||
| LegacyGroupName = "" |
| @@ -144,7 +144,7 @@ func TestDefaults(t *testing.T) { | |||
| } | |||
|
|
|||
| func roundTrip(t *testing.T, obj runtime.Object) runtime.Object { | |||
| data, err := runtime.Encode(codecs.LegacyCodec(LegacySchemeGroupVersion), obj) | |||
There was a problem hiding this comment.
@deads2k we won't test the legacy api roundtrip anymore?
There was a problem hiding this comment.
@deads2k we won't test the legacy api roundtrip anymore?
the default test was different. Before were only testing legacy, now we only test the version in the package.
|
one question /lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This plumbs up the new scheme install through all the groups and sets us up for creating separate schemes per process (or maybe even per server in our API servers). It will also allow us to start fixing the consumption of resources in oc
@juanvallejo @mfojtik