-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start tightening scheme usage in oc #20385
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
if [[ "$(du -m "${OS_OUTPUT_BINPATH}/${platform}/oc" | cut -f 1)" -gt "115" ]]; then | ||
os::log::fatal "oc binary has grown substantially. You must have approval before bumping this limit." | ||
ocsize=$(du -m "${OS_OUTPUT_BINPATH}/${platform}/oc" | cut -f 1) | ||
if [[ "${ocsize}" -gt "116" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1MB ? :-))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1MB ? :-))
Yeah, we were missing an api group.
@@ -31,6 +31,15 @@ import ( | |||
"github.com/openshift/origin/pkg/user/apis/user" | |||
) | |||
|
|||
func IsOAPI(gvk schema.GroupVersionKind) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe put a DEPRECATED label here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe put a DEPRECATED label here.
done
/retest |
2 similar comments
/retest |
/retest |
/hold |
New changes are detected. LGTM label has been removed. |
New changes are detected. LGTM label has been removed. |
/retest |
1 similar comment
/retest |
This builds on previous scheme installation fixes and printing protections to start collapsing onto the external only scheme in kubectl for reading and printing. It also fixes the upstream internally versioned commands which we inadvertently broke. We're winning!
/assign @juanvallejo @soltysh @mfojtik