-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make config scheme install normal #20471
make config scheme install normal #20471
Conversation
_ "github.com/openshift/origin/pkg/cmd/server/apis/config/install" | ||
) | ||
|
||
func TestGetPluginConfig(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deads2k where did this moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deads2k where did this moved?
This test was broken and the code also needs a bit of love since it is only intended to manage consuming a single type. I promise to come back to it.
seems like deep copy is failing and I have one test removal question, otherwise LGTM |
bf6af25
to
b057302
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This moves the config scheme towards normality and starts limiting entry points. I suspect we'll have a couple other significant changes in this area, but this got pretty large.
/assign @mfojtik