make config scheme install normal #20471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XL
mfojtik
reviewed
Jul 31, 2018
| _ "github.com/openshift/origin/pkg/cmd/server/apis/config/install" | ||
| ) | ||
|
|
||
| func TestGetPluginConfig(t *testing.T) { |
|
seems like deep copy is failing and I have one test removal question, otherwise LGTM |
deads2k
force-pushed
the
server-03-configapi
branch
from
bf6af25
to
b057302
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the config scheme towards normality and starts limiting entry points. I suspect we'll have a couple other significant changes in this area, but this got pretty large.
/assign @mfojtik