Don't auto-assign egress IPs that are no longer in use #20500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwinship
added
kind/bug
openshift-ci-robot
added
approved
danwinship
force-pushed
the
egress-ip-cleanup
branch
from
28aabb6
to
9132d51
Compare
|
@openshift/sig-networking PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EgressIPTracker has to keep track of every egress IP value that is referenced by either a node or a namespace, but we should not be auto-assigning egress IPs that are not currently assigned to a namespace.
First commit fixes the bug. Second commit GCs unused entries from the egressIPs map (which is related, but would not fix the bug on its own).
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1609112