Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 67093: improve config file modification time #20566

Merged
merged 1 commit into from
Aug 14, 2018
Merged

UPSTREAM: 67093: improve config file modification time #20566

merged 1 commit into from
Aug 14, 2018

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Aug 7, 2018 •
edited

In cases where there are few destination filenames for a given
amount of contexts, but a large amount of contexts, this patch
prevents reading and writing to the same file (or small number
of files) over and over again needlessly.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613075

cc @deads2k @soltysh @liggitt

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/improve-config-context-update branch from 0e576f9 to 8b699d2 Compare August 7, 2018 19:16
@juanvallejo juanvallejo changed the title UPSTREAM: 0000: improve config file modification time UPSTREAM: 67093: improve config file modification time Aug 7, 2018
@juanvallejo
Copy link
Contributor Author

UPSTREAM: kubernetes/kubernetes#67093

@juanvallejo
Copy link
Contributor Author

/test cmd

@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install

@juanvallejo juanvallejo force-pushed the jvallejo/improve-config-context-update branch 3 times, most recently from 069cd0d to dd8cf41 Compare August 9, 2018 19:47
@juanvallejo
Copy link
Contributor Author

@deads2k this pick is now up to date with the upstream PR

soltysh
soltysh approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2018
@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2018
@deads2k
Copy link
Contributor

deads2k commented Aug 10, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo
Copy link
Contributor Author

/test unit

@juanvallejo juanvallejo force-pushed the jvallejo/improve-config-context-update branch from dd8cf41 to 68ec3d8 Compare August 10, 2018 21:09
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2018
@juanvallejo
Copy link
Contributor Author

Getting a unit test failure due to a permission error when updating the starting kubeconfig path.
Updated to point to a temp file. Will patch upstream test if this works

@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo
Copy link
Contributor Author

/test gcp

@juanvallejo
Copy link
Contributor Author

Upstream PR updating test to match the changes from this PR: kubernetes/kubernetes#67347

@juanvallejo
UPSTREAM: 67093: improve config file modification time
0d9d5db 
Trades runtime complexity for spacial complexity when modifying
large amounts of contexts on a kubeconfig.

In cases where there are few destination filenames for a given
amount of contexts, but a large amount of contexts, this patch
prevents reading and writing to the same file (or small number
of files) over and over again needlessly.
@juanvallejo juanvallejo force-pushed the jvallejo/improve-config-context-update branch from 68ec3d8 to 0d9d5db Compare August 14, 2018 14:18
@juanvallejo
Copy link
Contributor Author

Upstream PR has been tagged. Re-lgtm'ing this one

@juanvallejo juanvallejo added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@openshift-merge-robot openshift-merge-robot merged commit 72fb9d6 into openshift:master Aug 14, 2018
@juanvallejo juanvallejo deleted the jvallejo/improve-config-context-update branch August 14, 2018 22:09
@juanvallejo juanvallejo mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juanvallejo @deads2k @openshift-ci-robot @soltysh @openshift-merge-robot