Backport retrieve node address logic from upstream #20615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plex logic into cloudResourceSyncManager
… (initializeModules) to avoid kubelet getting stuck in retrieving node addresses from a cloudprovider
openshift-ci-robot
added
the
size/L
|
@sjenning PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
Fails in the runs:
|
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
ingvagabund
deleted the
backport-retrieve-node-address-logic-from-upstream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of retrieving node address from a cloud provider was re-implemented. Instead of querying for node addresses each time a node status is updated, the node addresses are cached and provided. This allows the kubelet to limit the number of queries to a cloud provider and avoid timeouts/hangouts which would otherwise block the node status update loop.