-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <drop>: increase loglevel for health check #20616
UPSTREAM: <drop>: increase loglevel for health check #20616
Conversation
/retest |
/hold the point of the health check is to detect hung output. to detect that, we need to do something that triggers glog.Flush(). https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/healthz/healthz.go#L75-L89 would be a better way to do this. |
2c24f83
to
b7a7130
Compare
@liggitt fixed, thanks! |
/lgtm |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@liggitt i don't see this in current upstream nor in 1.11 branch. Do we carry this in rebase ?
Fixes: http://bugzilla.redhat.com/show_bug.cgi?id=1608109
/cc @smarterclayton