Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 65686: fix kubectl create priorityclass failure bug #20624

Merged
merged 1 commit into from
Aug 15, 2018
Merged

UPSTREAM: 65686: fix kubectl create priorityclass failure bug #20624

merged 1 commit into from
Aug 15, 2018

Conversation

juanvallejo
Copy link
Contributor

soltysh
soltysh approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Aug 14, 2018

/refresh

@juanvallejo
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 568c838 into openshift:master Aug 15, 2018
@juanvallejo juanvallejo deleted the jvallejo/pick-upstream-65686 branch August 15, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juanvallejo @openshift-ci-robot @soltysh @openshift-merge-robot