React to imagelayers API changes #20643
Conversation
openshift-ci-robot
added
size/XL
smarterclayton
force-pushed
the
bump_image_api
branch
2 times, most recently
from
36f829f
to
794d7bc
Compare
|
/retest |
|
@smarterclayton this adds the field for roundtripping, but doesn't appear to set the value. |
|
It does not, I was trying to make sure we still compiled.
…On Wed, Aug 15, 2018 at 1:48 PM David Eads ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton> this adds the field
for roundtripping, but doesn't appear to set the value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20643 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p7GYkdodkgic8y0C7DgAhELoHbYBks5uRF7XgaJpZM4V9IxQ>
.
|
|
/retest |
smarterclayton
force-pushed
the
bump_image_api
branch
from
794d7bc
to
6ed62a6
Compare
|
Updated with e2e and imageMissing logic |
smarterclayton
force-pushed
the
bump_image_api
branch
from
6ed62a6
to
786c7ed
Compare
openshift-ci-robot
added
size/M
|
This is now just the imageMissing change (bump done elsewhere) |
|
/retest |
|
@bparees please review |
|
no other code changes needed to adjust to the missing image marker? |
|
(or a followup PR is needed in image-registry once this merges?) |
|
In this case no, registry works fine because we serve the manifest to the
client if we have based on whether the image stream references it, not
whether the image references it. If the image object doesn't exist we can
still serve the raw manifest.
…On Fri, Aug 17, 2018 at 2:53 PM Ben Parees ***@***.***> wrote:
(or a followup PR is needed in image-registry once this merges?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20643 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p_fSNBN2B4aNuCybimpuNyvtnkGTks5uRxETgaJpZM4V9IxQ>
.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.