-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1614660 - Network diagnostic will auto detect runtime #20647
Bug 1614660 - Network diagnostic will auto detect runtime #20647
Conversation
Don't default to crio runtime when crio and docker binaries are installed. Node object has the container runtime version, so now we fetch the runtime info from there.
…iags This seems fallout from 1.11 rebase (openshift#20033)
@openshift/sig-network-edge PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@@ -7,8 +7,7 @@ import ( | |||
"regexp" | |||
"strings" | |||
|
|||
"github.com/golang/glog" | |||
|
|||
kclientset "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, I'm pretty sure we should be using the public client APIs in k8s.io/client-go
.
Follow up of openshift#20647 We could have some nodes running crio and others with docker runtime. Starter clusters are doing this but this could change with 4.0+ release. Fetch the runtime info from the local node object so that it works on all cases.
Don't default to crio runtime when crio and docker binaries are installed.
Node object has the container runtime version, so now we fetch the runtime
info from there.
Fix provided options object is not a PodLogOptions error in network diags
This seems fallout from 1.11 rebase (#20033)