-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 67236: fix azure disk create failure due to sdk upgrade #20662
Conversation
@openshift/storage please review, thank you. |
@openshift/sig-storage * |
@@ -488,7 +488,9 @@ func (c *BlobDiskController) createStorageAccount(storageAccountName string, sto | |||
glog.V(2).Infof("azureDisk - Creating storage account %s type %s", storageAccountName, string(storageAccountType)) | |||
|
|||
cp := storage.AccountCreateParameters{ | |||
Sku: &storage.Sku{Name: storageAccountType}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, something ate the indentation. :-)
/lgtm |
/assign @smarterclayton |
/lgtm Over to you @smarterclayton |
/approve |
/approve
…On Tue, Aug 21, 2018 at 3:50 PM OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *childsb
<#20662 (comment)>*, *gnufied
<#20662 (comment)>*, *knobunc
<#20662 (comment)>*, *wongma7
<#20662#>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: *smarterclayton*
If they are not already assigned, you can assign the PR to them by writing /assign
@smarterclayton in a comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- *vendor/k8s.io/kubernetes/pkg/OWNERS
<https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20662 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p94jgWk7iJn8Ffy5nOQYsc5GlxzOks5uTGRwgaJpZM4V-wL8>
.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: childsb, gnufied, knobunc, smarterclayton, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
fix https://bugzilla.redhat.com/show_bug.cgi?id=1613676