further fully-automatic-egress-IP cleanup #20718
Conversation
danwinship
added
kind/bug
openshift-ci-robot
added
size/M
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@danwinship: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-bot
added
the
needs-rebase
|
@danwinship: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
merged as part of #20485 |
After an Egress IP is auto-assigned to a HostSubnet for a namespace, if you remove all EgressIPs from the namespace, it does not get removed from the HostSubnet.
This was already fixed by the changes in #20485, and I've pushed the new unit test there as well, but since that's been slow to get reviewed I thought I'd submit this simpler version as well (which is just one of the commits from #20485 plus a new unit test).
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1609112