-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accept --kubeconfig like kubectl #20721
accept --kubeconfig like kubectl #20721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and you're good to go.
test/cmd/login.sh
Outdated
@@ -106,12 +106,13 @@ os::cmd::expect_success 'oc get projects' | |||
os::cmd::expect_success 'oc project project-foo' | |||
os::cmd::expect_success_and_text 'oc config view' "current-context.+project-foo/${API_HOST}:${API_PORT}/test-user" | |||
os::cmd::expect_success_and_text 'oc whoami' 'test-user' | |||
os::cmd::expect_success_and_text "oc whoami --config='${login_kubeconfig}'" 'system:admin' | |||
os::cmd::expect_success_and_text "oc whoami --kubeconfig='${login_kubeconfig}'" 'system:admin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you wanted one to be --config
to verify it still works, right?
16a6227
to
8045bb4
Compare
updated. |
8045bb4
to
f20c0a4
Compare
/retest |
1 similar comment
/retest |
/approve
…On Wed, Aug 22, 2018 at 7:41 PM David Eads ***@***.***> wrote:
/retest
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20721 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8y2NNEdvvYSTS4lEStOo48eoR0Uks5uTewygaJpZM4WGmdo>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
One of the final remaining
oc
/kubectl
inconsistencies is--kubeconfig
. We take--config
instead, but that collides in commands taking config in weird ways. This updatesoc
to accept either for the time being.@openshift/cli-review
I doubt we get to drop
--config
support anytime soon, but this gives us compatibility and we could write a decent plugin after this@smarterclayton I think this is the last big one
/assign @soltysh