Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 68007: Orphan DaemonSet when deleting with --cascade option set #20793

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Aug 29, 2018

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2018
@juanvallejo
Copy link
Contributor

lgtm, could we maybe add a test for this?

@soltysh
Copy link
Member Author

soltysh commented Aug 29, 2018

I wouldn't bother, this is ONLY in 3.11, the next release does not have this code path.

@mfojtik
Copy link
Contributor

mfojtik commented Aug 29, 2018

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member Author

soltysh commented Aug 29, 2018

/hold
There's a bug that @tnozicka pointed out in the upstream PR.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2018
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@soltysh
Copy link
Member Author

soltysh commented Aug 30, 2018

Fixed the error @tnozicka pointed out.

/hold cancel

Re-applying labels back.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2018
@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2018
@openshift-merge-robot openshift-merge-robot merged commit 5686cdc into openshift:master Aug 30, 2018
@soltysh soltysh deleted the bug1623352 branch August 30, 2018 11:01
@soltysh
Copy link
Member Author

soltysh commented Aug 30, 2018

@deads2k not sure who will be in charge of the next rebase, but heads up that although this is a valid upstream PR it should be dropped during next rebase since this path is removed in 1.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants