hack: copy oc to kubectl #20935
hack: copy oc to kubectl #20935
Conversation
openshift-ci-robot
added
approved
mfojtik
force-pushed
the
hack-66-fix-kubectl-copy
branch
from
f198c7b
to
39790af
Compare
|
/retest |
mfojtik
force-pushed
the
hack-66-fix-kubectl-copy
branch
from
39790af
to
324c623
Compare
|
/cherrypick release-3.11 |
|
@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
| @@ -330,6 +330,18 @@ function os::build::place_bins() { | |||
| fi | |||
| done | |||
|
|
|||
| # Link binaries that we want to link (eg. oc->kubectl) | |||
There was a problem hiding this comment.
Why we care about the link, when we'll copy it over a few lines below?
There was a problem hiding this comment.
Nvmd, I haven't seen the dest being different for both.
|
/retest |
|
@smarterclayton any idea why the gcp job failed? |
mfojtik
force-pushed
the
hack-66-fix-kubectl-copy
branch
from
324c623
to
fa5bbff
Compare
|
@smarterclayton ok, check the last commit... it seems like in bash, the array declaration can't be on the same line as the function invocation, which is ridiculous... anyway, with the last commit, I think I got kubectl in place where we want it https://gist.github.com/mfojtik/815b18a3859d4f6949fc902d7960e410 |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, tbielawa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
merged by hand, don't care. I'm a honey badger. |
|
@mfojtik: new pull request created: #20958 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @smarterclayton