Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodeenv plugin and DS controller to not process openshift.io/node-selector if scheduler.alpha.kubernetes.io/node-selector is set on pods namespace #21058

Conversation

aveshagarwal
Copy link
Contributor

…notation

key scheduler.alpha.kubernetes.io/node-selector in nodeenv admission plugin.
openshift-io/node-selector if scheduler.alpha.kubernetes.io/node-selector is set.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2018
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2018
@aveshagarwal
Copy link
Contributor Author

/test gcp

3 similar comments
@aveshagarwal
Copy link
Contributor Author

/test gcp

@sjenning
Copy link
Contributor

/test gcp

@aveshagarwal
Copy link
Contributor Author

/test gcp

@sjenning
Copy link
Contributor

I'm seeing

2018/09/20 15:13:20 Build hyperkube failed, printing logs:

in the build-log.txt but there is nothing after that. There are not logs printed below that. I checked out the branch locally and hyperkube builds fine for me.

@sjenning
Copy link
Contributor

Well we are past the hyperkube build step this time 👍

@aveshagarwal
Copy link
Contributor Author

Well we are past the hyperkube build step this time +1

keeping fingers crossed.

@openshift-merge-robot openshift-merge-robot merged commit 3194805 into openshift:release-3.11 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants