Temporarily force the installer to be part of the payload #21637
Conversation
It should instead be referenced by another component, but include it here until we can identify what that is. This gives us installer reproducibility for hive.
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Force merging so we can track an installer version if we have to cut one this week. |
|
Does this still leave us in a spot where we ref a payload for a stable tagged build, extract the installer version, but that installer version is not properly pinned to that release payload? (per @wking comments in our thread last week) |
Yeah, you'd want to set |
Take advantage of openshift/origin@59dab63d (Temporarily force the installer to be part of the payload, 2018-12-08, openshift/origin#21637) to avoid installer/update-payload mismatches. This does not address install-config.yaml/installer mismatches, but it's a step in the right direction. Also: * Replace 'shell' syntax highlighting with 'console', because these blocks have prompts. And switch from the traditionally-PS2 '>' to the traditionally-PS1 '$' for those prompts. * Stop exporting variables that are not needed by subprocesses. * Drop OPENSHIFT_INSTALL_*. This information is provided via install-config.yaml, and the installer ignores the environment variables since openshift/installer@6be4c253 (*: remove support for environment variables, 2018-12-10, openshift/installer#861). There's an outstanding FIXME while I wait for guidance about who's job it is to pull the installer image out of the update payload. If we do that in generate.go, we need to vendor some not-really-designed-as-a-library origin code. If we do it in the launched container, we need both oc and Podman (or some other way to actually run the discovered installer image).
It should instead be referenced by another component, but include it here
until we can identify what that is. This gives us installer reproducibility
for hive.