Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tunneling to masters over SSH for e2e tests #21700

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Dec 21, 2018

Workers are now private, which means we can't directly connect to
them. For now, make the e2e tests tolerate a bastion hop by
proxying the SSH connection from a given instance.

TODO:

Blocks moving away from e2e-gcp because some tests still depend on SSH https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-all-4.0/18/

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2018
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/test e2e-gcp

@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

1 similar comment
@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2018
Workers are now private, which means we can't directly connect to
them. For now, make the e2e tests tolerate a bastion hop by
proxying the SSH connection from a given instance.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 25, 2018
@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

2 similar comments
@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

@smarterclayton
Copy link
Contributor Author

/test e2e-aws-all

@smarterclayton
Copy link
Contributor Author

/skip e2e-aws-all

@smarterclayton
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp c6655ab link /test e2e-gcp
ci/prow/e2e-aws-all c6655ab link /test e2e-aws-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2018
@smarterclayton smarterclayton changed the title WIP: Support tunneling to masters over SSH for e2e tests Support tunneling to masters over SSH for e2e tests Dec 26, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2018
@smarterclayton
Copy link
Contributor Author

Node port tests still need to be fixed, that will be a follow up.

@soltysh I will create a pick of this to your rebase branch, but with this change there should only be 10 or so aws-all failures (taints and node ports are the only two broken areas)

@smarterclayton smarterclayton merged commit 68f76d2 into openshift:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants