Upgrade osin, increase entropy in tokens #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarterclayton PTAL |
|
I've meaning to get some more entropy. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/1969/) (Image: devenv-fedora_1546) |
|
Evaluated for origin up to e715af2 |
openshift-bot
pushed a commit
that referenced
this pull request
May 16, 2015
Merged by openshift-bot
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateparam for the implicit oauth flow (https://github.com/openshift/origin/pull/2288/files#diff-6979cfdf6b487f5f3be424a1d4496b9cR227)/characters in token namesWe were previously doing:
This made 122 random bits take about 49 characters to represent. If we skip the hex encoding step, we can get 244 random bits in about 44 characters.