Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1772451: vendor: bump etcd, bbolt and gRPC-go #24149

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Bug 1772451: vendor: bump etcd, bbolt and gRPC-go #24149

merged 2 commits into from
Nov 15, 2019

Conversation

hexfusion
Copy link
Contributor

After etcd v3.3.15 was released a few major bugs were exposed and were patched through v3.3.17. The bump to etcd was part of kube 1.16.3 but as OpenShift is pinned to 1.16.2 these changes are being introduced by a dependency bump for etcd and bbolt.

  • "etcd client does not parse IPv6 addresses correctly when members are joining" [1] fixed via [2]
  • "kube-apiserver: failover on multi-member etcd cluster fails certificate check on DNS mismatch" [3] fixed via [4]

[1] kubernetes/kubernetes#83550
[2] etcd-io/etcd#11211
[3] kubernetes/kubernetes#83028
[4] etcd-io/etcd#11184

UPSTREAM: 83970: Bump bbolt to v1.3.3

Kubernetes-commit: 1db282b

UPSTREAM: 83801: Upgrade to etcd client 3.3.17

Kubernetes-commit: 41e03d2

Signed-off-by: Sam Batschelet sbatsche@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 13, 2019
@hexfusion hexfusion changed the title vendor: bump etcd to v3.3.17 and bbolt to v1.3.3 vendor: bump etcd, bbolt and gRPC-go Nov 14, 2019
@hexfusion
Copy link
Contributor Author

/cc @deads2k @smarterclayton

@hexfusion hexfusion changed the title vendor: bump etcd, bbolt and gRPC-go Bug 1772451: vendor: bump etcd, bbolt and gRPC-go Nov 14, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 14, 2019
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1772451, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1772451: vendor: bump etcd, bbolt and gRPC-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 14, 2019
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1772451, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Nov 14, 2019

/lgtm
/hold
holding so you can see if you can use a tag instead for etcd. If not, feel free remove hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2019
@hexfusion
vendor: bump etcd to v3.3.17 and bbolt to v1.3.3
27d32a5 
UPSTREAM: 83970: Bump bbolt to v1.3.3

Kubernetes-commit: 1db282b

UPSTREAM: 83801: Upgrade to etcd client 3.3.17

Kubernetes-commit: 41e03d2

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
vendor: bump gRPC-go to v1.23.0
a935ae8 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@deads2k
Copy link
Contributor

deads2k commented Nov 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor Author

tag worked fine and updated
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

/test e2e-cmd

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b4935d3 into openshift:master Nov 15, 2019
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged. Bugzilla bug 1772451 has been moved to the MODIFIED state.

In response to this:

Bug 1772451: vendor: bump etcd, bbolt and gRPC-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the bump_etcd branch November 15, 2019 15:50
@hexfusion
Copy link
Contributor Author

/cc @abhinavdahiya @crawford @sjenning @wking just FYI.

@hexfusion hexfusion mentioned this pull request Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@tbielawa tbielawa Awaiting requested review from tbielawa

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hexfusion @openshift-ci-robot @deads2k @openshift-bot @openshift-merge-robot