Bug 1793340: Revert "images/tests: Globally-writeable /etc/passwd" #24556
Conversation
This reverts commit ca35cd6, openshift#22592. As described in that commit message, the access was broadened to allow ssh from containers launched from the tests image. But since openshift/release@7baa9f2e44 (ci-operator/templates/openshift: Remove Terraform-state-based SSH gathers, 2020-01-25, openshift/release#6854) landed, we no longer need to SSH from those containers. Restore the usual access restrictions to address CVE-2019-19347[1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1793287
|
@wking: This pull request references Bugzilla bug 1793340, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@wking: This pull request references Bugzilla bug 1793340, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
@staebler FYI |
|
Failures look unrelated. /retest |
|
@sdodson, Prow seems to have missed your lgtm/approve. Resend? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, sttts, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@wking: All pull requests linked via external trackers have merged. Bugzilla bug 1793340 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit ca35cd6, #22592.
As described in that commit message, the access was broadened to allow
sshfrom containers launched from the tests image. But since openshift/release@7baa9f2e44 (openshift/release#6854) landed, we no longer need to SSH from those containers. Restore the usual access restrictions to address CVE-2019-19347.