Bug 1992596: e2e/cli: Move annotations.sh to proper e2e #26410
Conversation
openshift-ci
bot
added
bugzilla/severity-medium
|
@deejross: This pull request references Bugzilla bug 1992596, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @soltysh |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deejross, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| os::test::junit::declare_suite_end | ||
|
|
||
| os::test::junit::declare_suite_start "cmd/label" | ||
| # This test validates empty values in key-value pairs set by the label command |
There was a problem hiding this comment.
can we also include the tests for empty values?
There was a problem hiding this comment.
Latest commit includes removing annotations and labels and validating they are empty
There was a problem hiding this comment.
I was asking specifically for the test we have here (key exists with empty value)
|
/retest-required |
|
@deejross: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| o.Expect(out).To(o.Equal("hello")) | ||
|
|
||
| g.By("removing the annotation") |
There was a problem hiding this comment.
+1, having additional test doesn't hurt anything
|
The test as currently written points to the "openshift/hello-openshift" image, which is not multi-arch enabled. This will cause these tests to fail in both disconnect installs, and on any install on non-x86 architectures. Please rework this test according to the procedures for e2e test images. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@yselkowitz I ran into something similar with the next PR where the old bash scripts were using images that weren't allowed. That PR #26415 includes several fixes for these types of issues, and I'm considering closing this one and moving it over there to take advantage of the newer resource builder which uses approved e2e images. |
|
This has been moved into #26415 to better handle multi-arch and disconnected installs. |
|
@deejross: This pull request references Bugzilla bug 1992596. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This moves the testing from a bash script to a Ginkgo test files.