Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1870: Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES #29247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

candita
Copy link
Contributor

@candita candita commented Oct 30, 2024

Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES.

modified: OWNERS_ALIASES
new file: test/extended/dns/OWNERS
modified: test/extended/router/OWNERS

files and add aliases to OWNERS_ALIASES.

modified:   OWNERS_ALIASES
new file:   test/extended/dns/OWNERS
modified:   test/extended/router/OWNERS
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2024

@candita: This pull request references NE-1865 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES.

modified: OWNERS_ALIASES
new file: test/extended/dns/OWNERS
modified: test/extended/router/OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita
Copy link
Contributor Author

candita commented Oct 30, 2024

/assign @gcs278

@gcs278
Copy link
Contributor

gcs278 commented Oct 30, 2024

Seems straightforward.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: candita, gcs278
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@candita
Copy link
Contributor Author

candita commented Oct 30, 2024

e2e-aws-ovn-microshift - failure in [sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router converges when multiple routers are writing conflicting status [Suite:openshift/conformance/parallel]

{  fail [github.com/openshift/origin/test/extended/router/stress.go:212]: Unexpected error:
    <wait.errInterrupted>: 
    timed out waiting for the condition
    {
        cause: <*errors.errorString | 0xc000094910>{
            s: "timed out waiting for the condition",
        },
    }

@candita
Copy link
Contributor Author

candita commented Oct 30, 2024

/retest

@candita
Copy link
Contributor Author

candita commented Oct 30, 2024

Hi @stbenjam - please take a look and approve or let me know if there is an issue.

/assign @stbenjam

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: f41f967

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Low
[sig-node] static pods should start after being created
This test has passed 78.92% of 185 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

Open Bugs
Static pod controller pods sometimes fail to start [kube-controller-manager]
Static pod controller pods sometimes fail to start [etcd]
---
[sig-node] static pods should start after being created
This test has passed 79.35% of 184 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

Open Bugs
Static pod controller pods sometimes fail to start [kube-controller-manager]
Static pod controller pods sometimes fail to start [etcd]

@candita
Copy link
Contributor Author

candita commented Oct 31, 2024

More problems with etc static pods.
/test e2e-aws-ovn-single-node-upgrade

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@candita: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade f41f967 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@candita candita changed the title NE-1865: Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES NE-1870: Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES Nov 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2024

@candita: This pull request references NE-1870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fix the Network Ingress & DNS OWNERS files and add aliases to OWNERS_ALIASES.

modified: OWNERS_ALIASES
new file: test/extended/dns/OWNERS
modified: test/extended/router/OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita
Copy link
Contributor Author

candita commented Nov 4, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2024

@candita: This pull request references NE-1870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita
Copy link
Contributor Author

candita commented Nov 13, 2024

Ping @deads2k @stbenjam for approval. Plmk if there are any questions.

@candita
Copy link
Contributor Author

candita commented Nov 22, 2024

Ping @deads2k @stbenjam for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants