Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDN-5473: OVN-K: Port e2e tests for CUDN functionality, connectivity and isolation #29274

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

SDN-5473: OVN-K: Port e2e tests for CUDN functionality, connectivity and isolation #29274

wants to merge 6 commits into from

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Nov 7, 2024 •
edited
Loading

This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by ovn-kubernetes/ovn-kubernetes#4612.

Note to reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ormergi ormergi changed the title OVN-K: Port e2e ClusterUDN controller functionality, connectivity and isolation OVN-K: Port e2e tests for CUDN functionality, connectivity and isolation Nov 7, 2024
@ormergi ormergi changed the title OVN-K: Port e2e tests for CUDN functionality, connectivity and isolation SDN-5473: OVN-K: Port e2e tests for CUDN functionality, connectivity and isolation Nov 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024 •
edited by openshift-ci bot
Loading

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by ovn-kubernetes/ovn-kubernetes#4612.

Note to reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Nov 12, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

@ormergi: The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-microshift
  • /test e2e-aws-ovn-microshift-serial
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-certrotation
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-ipsec-serial
  • /test e2e-aws-ovn-kube-apiserver-rollout
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-techpreview
  • /test e2e-aws-ovn-single-node-techpreview-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upgrade-rollback
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-ovn-virt-techpreview
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-azure-ovn-upgrade
  • /test e2e-baremetalds-kubevirt
  • /test e2e-external-aws
  • /test e2e-external-aws-ccm
  • /test e2e-external-vsphere-ccm
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-local-gateway
  • /test e2e-metal-ipi-ovn-kube-apiserver-rollout
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-ovn-single-node-live-iso
  • /test e2e-metal-ovn-single-node-with-worker-live-iso
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout
  • pull-ci-openshift-origin-master-e2e-aws-ovn-microshift
  • pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ormergi
Copy link
Contributor Author

ormergi commented Nov 12, 2024

/test e2e-gcp-ovn-techpreview

@ormergi
test,networksegmentation: Test cluster UDN management using CRD
164ebd8 
Add tests for OVN-Kubernetes user-defined-network management using
ClusterUserDefinedNetwork CRD.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2024 •
edited by openshift-ci bot
Loading

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by ovn-kubernetes/ovn-kubernetes#4612.

Note to reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Nov 14, 2024

/test e2e-gcp-ovn-techpreview

@jluhrsen
Copy link
Contributor

your tests are not registered with the label [Suite:openshift/conformance/parallel] and that's what we are running in that job with openshift-tests run openshift/conformance/parallel.
You can get that fixed by running make update
you can check locally with this command:

before make update

❯ ./openshift-tests run openshift/conformance/parallel --dry-run | rg 'should create NAD according to spec in each target namespace and report active namespaces'
I1114 14:15:55.181022 1641198 factory.go:193] Registered Plugin "containerd"
INFO[0000] Decoding provider                             clusterState="<nil>" discover=true dryRun=true func=DecodeProvider providerType=

after make update

❯ ./openshift-tests run openshift/conformance/parallel --dry-run | rg 'should create NAD according to spec in each target namespace and report active namespaces'
I1114 14:18:09.348749 1642240 factory.go:193] Registered Plugin "containerd"
INFO[0000] Decoding provider                             clusterState="<nil>" discover=true dryRun=true func=DecodeProvider providerType=
"[sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller should create NAD according to spec in each target namespace and report active namespaces [Suite:openshift/conformance/parallel]"

@ormergi
test,networksegmentation: connectivity & isolation coverage using CUDN
537c033 
Add additional case using the ClusterUserDefinedNetwork CRD for UDN
connectivity and isolation tests.

Since CUDN CRD is cluster scoped, it should be deleted after each test.
Delete tests pods as part of the CUDN clean-up to unblock CR and associated
NADs to deletion

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
Copy link
Contributor Author

ormergi commented Nov 15, 2024 •
edited
Loading

@jluhrsen thank you!

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ormergi
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ormergi
Copy link
Contributor Author

ormergi commented Nov 15, 2024

/test e2e-gcp-ovn-techpreview

@ormergi
test,networksegmentation: Wait for CUDN status populate in primary ne…
49a887e 
…twork exist test

Signed-off-by: Or Mergi <ormergi@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2024 •
edited by openshift-ci bot
Loading

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by ovn-kubernetes/ovn-kubernetes#4612.

Note to reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Nov 17, 2024

/test e2e-gcp-ovn-techpreview

@ormergi
Copy link
Contributor Author

ormergi commented Nov 17, 2024

/test e2e-gcp-ovn-techpreview

@ormergi
Copy link
Contributor Author

ormergi commented Nov 19, 2024

/test e2e-gcp-ovn-techpreview

@ormergi
test,networksegmentation: Wait for CUDN object be gone
93de92f 
On CUDN cleanup is inconsistent as we see some flaky tests due to CUDN
"already exist" errors, implying object are not actually deleted.

Wait for CUDN object be gone when deleted.

The expected "not-found" error assertion checks the error string instead
because the tests framework client returns error in a custom format causing
the error to not match the standard k8s "no-found" typed error.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
Copy link
Contributor Author

ormergi commented Nov 20, 2024

/test e2e-gcp-ovn-techpreview

1 similar comment
@ormergi
Copy link
Contributor Author

ormergi commented Nov 20, 2024

/test e2e-gcp-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@ormergi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ormergi
test, networksegmentation: Use random names for CUDN objects
a185dc5 
CUDN is cluster-scoped object, in case tests running in parallel,
having random names avoids conflicting with other tests.

Use random name for related network object metadata.name, such as NAD,
UDN and CUDN.

The "isolates overlapping CIDRs" tests create multiple network objects
based on the 'red' and 'blue' variables, change these vars to have
random names.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
test, networksegmentation: Set PSA on pod that run in test namespace
5bbf48f 
The following test create new namespace and a pod inside it, the pod
because it doesnt meet cluster PSA.
[sig-network][OCPFeatureGate:NetworkSegmentation]
[Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes
ClusterUserDefinedNetwork CRD Controller pod connected to
ClusterUserDefinedNetwork CR & managed NADs cannot be deleted when being used

Set the tested pod with PSA to meet the cluster PSA.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2024 •
edited by openshift-ci bot
Loading

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by ovn-kubernetes/ovn-kubernetes#4612.

Note to reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Nov 21, 2024

/test e2e-gcp-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@ormergi: No presubmit jobs available for openshift/origin@master

In response to this:

/test e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ormergi @openshift-ci-robot @jluhrsen