Skip to content

Commit

Permalink
image*.yaml: Enable injection of OCP machine-os metadata by default
Browse files Browse the repository at this point in the history
This is implemented by coreos/coreos-assembler#3153

We had these in the legacy oscontainer for RHCOS, and OKD today hacks them in via a Dockerfile:
https://github.com/openshift/okd-machine-os/blob/0e9fbabbd3363bfc46d9d657bc173666e83e5d18/Dockerfile#L34

We need to carry support for this forward into the new format image, as it's what is used to display the OS version as part of the release image.

Also xref https://issues.redhat.com/browse/TRT-647
  • Loading branch information
cgwalters committed Nov 1, 2022
1 parent bbafe62 commit f4646dc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions image-rhel-8.6.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ squashfs-compression: gzip
# defaulting to `ip=dhcp,dhcp6 rd.neednet=1` when it doesn't see this key.
ignition-network-kcmdline: []

# Keep OCP metadata on our container image, but xref https://github.com/openshift/os/issues/1047
ostree-container-inject-openshift-cvo-labels: true

# vmware-secure-boot changes the EFI secure boot option.
# set false here due to https://bugzilla.redhat.com/show_bug.cgi?id=2106055
vmware-secure-boot: false
Expand Down
3 changes: 3 additions & 0 deletions image-rhel-9.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ size: 16
# defaulting to `ip=dhcp,dhcp6 rd.neednet=1` when it doesn't see this key.
ignition-network-kcmdline: []

# Keep OCP metadata on our container image, but xref https://github.com/openshift/os/issues/1047
ostree-container-inject-openshift-cvo-labels: true

# vmware-secure-boot changes the EFI secure boot option.
# set false here due to https://bugzilla.redhat.com/show_bug.cgi?id=2106055
vmware-secure-boot: false
Expand Down

0 comments on commit f4646dc

Please sign in to comment.