Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to libsemanage-2.9-8.el8 #1037

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Oct 25, 2022

With -9.el8, ext.config.rebuild-selinux-policy fails:
#1036

We need to debug this, but for now let's unblock CI and dev pipelines.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
With -9.el8, `ext.config.rebuild-selinux-policy` fails:
openshift#1036

We need to debug this, but for now let's unblock CI and dev pipelines.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@jlebon
Copy link
Member Author

jlebon commented Oct 25, 2022

Though thinking more on this, having the policy be recompiled on first boot is really not great and may affect other things, so let's pin instead. I've verified locally that this unbreaks the test.

@jlebon jlebon changed the title kola-denylist: deny ext.config.rebuild-selinux-policy for now Pin to libsemanage-2.9-8.el8 Oct 25, 2022
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,jlebon,marmijo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Oct 26, 2022

SCOS failures look like distinct issues. The pin added here can only affect RHCOS 8.6, whose associated tests did pass.

/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

SCOS failures look like distinct issues. The pin added here can only affect RHCOS 8.6, whose associated tests did pass.

/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon merged commit 3db99d6 into openshift:master Oct 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlebon jlebon deleted the pr/deny-selinux branch October 26, 2022 01:16
@HuijingHei
Copy link
Contributor

Same error on 4.11, need to backport to 4.11
/cherrypick release-4.11

@openshift-cherrypick-robot

@HuijingHei: #1037 failed to apply on top of branch "release-4.11":

Applying: Pin to libsemanage-2.9-8.el8
Using index info to reconstruct a base tree...
A	manifest-rhel-8.6.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): manifest-rhel-8.6.yaml deleted in HEAD and modified in Pin to libsemanage-2.9-8.el8. Version Pin to libsemanage-2.9-8.el8 of manifest-rhel-8.6.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Pin to libsemanage-2.9-8.el8
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Same error on 4.11, need to backport to 4.11
/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuijingHei added a commit to HuijingHei/os that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants