Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kola-denylist: Add a few ext.config.shared.networking #1095

Merged
merged 1 commit into from
Dec 13, 2022
Merged

kola-denylist: Add a few ext.config.shared.networking #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions kola-denylist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,20 @@
osversion:
- c9s
snooze: 2022-11-15

- pattern: ext.config.shared.networking.force-persist-ip
tracker: https://github.com/fedora-selinux/selinux-policy/commit/c86d943538f907c2e6b20ffda0a8d2b5b5bd2e34
osversion:
- rhel-9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's snooze them until e.g. mid-January? Snoozing isn't the best UX, but it's a crude way to ensure we don't keep disabling those tests well past when they're no longer needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the tests will ever pass in rhel 9.0. Note the dot-zero.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I think ideally these tests should be skipped on RHEL 9.0 entirely. We have distros, but I don't think we can limit per version yet, but it could make sense to add.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, though in practice what I think will happen is that we branch and main/master retargets for 9.2 at some point where this is already fixed.

Another way to say this is - the tests should automatically be un-denied when we retarget, which is the main goal.

- pattern: ext.config.shared.networking.mtu-on-bond-kargs
tracker: https://github.com/fedora-selinux/selinux-policy/commit/c86d943538f907c2e6b20ffda0a8d2b5b5bd2e34
osversion:
- rhel-9.0
- pattern: ext.config.shared.networking.no-persist-ip
tracker: https://github.com/fedora-selinux/selinux-policy/commit/c86d943538f907c2e6b20ffda0a8d2b5b5bd2e34
osversion:
- rhel-9.0
- pattern: ext.config.shared.networking.prefer-ignition-networking
tracker: https://github.com/fedora-selinux/selinux-policy/commit/c86d943538f907c2e6b20ffda0a8d2b5b5bd2e34
osversion:
- rhel-9.0