common.yaml: stop using initramfs-args in favour of dracut.conf.d dropins
#1376
Conversation
These are all already specified in the `dracut.conf.d` dropins we inherit from FCOS. Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
Add context links from git archeology while we're here. Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
This dates back from when we wanted to use NetworkManager in the initrd before it was the default (in RHEL8). It's the default now, so we don't need it anymore. Remove related commented-out lines in `common.yaml` while we're here. Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
Awesome series. I assume so but worth verifying: Did you compare the before/after of the lsinitrd?
Also tangentially related to:
It just stops uselessly generating ifcfg files in the initrd.
Could this be related to https://github.com/openshift/machine-config-operator/blob/master/templates/common/_base/files/NetworkManager-clean-initrd-state.yaml which I started to look at and then recoiled in horror and closed the tab...
It's included by default currently so we don't need this. A patch in FCOS will actually make it so that we don't pull it in at all: coreos/fedora-coreos-config#2642 Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
`ignition` is already pulled in by a multitude of dracut modules, and `fips` is already pulled in by `rhcos-fips`. Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
The `iscsi` module is already included by default in a non-hostonly initramfs. Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
jlebon
force-pushed
the
pr/cleanup-initramfs-args
branch
from
34dd3c7
to
d73ccaf
Compare
|
I hadn't checked closely the diff, but I did now and one thing that jumps out is that |
|
To be clear, this needs to wait until coreos/fedora-coreos-config#2640 lands in RHCOS. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
I'm not sure what that script is doing. It seems to be doing something that shouldn't normally be necessary and doesn't talk about how it intersects with the teardown scripts we have and the existing behaviour of not stomping on user configs. Probably deserves a chat with the team that introduced it. |
|
/lgtm |
This landed as part of #1371. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The field is deprecated:
coreos/rpm-ostree#3834
See individual commit messages for details.
Closes: #1377