Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch coreos.ignition.failure err on 4.16 pipeline #1406

Closed
wants to merge 1 commit into from

Conversation

c4rt0
Copy link
Contributor

@c4rt0 c4rt0 commented Dec 14, 2023

After failing to reproduce coreos.ignition.failure locally I am removing it from denylist in order to catch errors in the pipeline. The goal of this PR is to allow it in RHCOS 4.16, catch the errors from the log and re-introduce coreos.ignition.failure to kola-denylist while working on solution.

See: coreos/coreos-assembler#3670

After failing to reproduce `coreos.ignition.failure` locally I am removing it from denylist in order to catch errors in the pipeline. The goal of this PR is to allow it in RHCOS 4.16, catch the errors from the log and re-introduce `coreos.ignition.failure` to kola-denylist while working on solution.

See: coreos/coreos-assembler#3670
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@jschintag
Copy link
Contributor

Why not point the pipeline to your own branch of this repo instead, using the dev pipeline?

@c4rt0
Copy link
Contributor Author

c4rt0 commented Dec 14, 2023

Why not point the pipeline to your own branch of this repo instead, using the dev pipeline?

Oh, that's a good suggestion. Let me investigate and find out how to do it.

@jschintag
Copy link
Contributor

Oh, that's a good suggestion. Let me investigate and find out how to do it.

I think you would either need your own repository for pipeline config or point the dev one at your fork of this repo.
So Pipeline -> custom config -> custom openshift/os -> profit

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@c4rt0: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-92-build-test-qemu fdb7b96 link true /test rhcos-92-build-test-qemu
ci/prow/scos-9-build-test-qemu fdb7b96 link true /test scos-9-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuijingHei
Copy link
Contributor

Oh, that's a good suggestion. Let me investigate and find out how to do it.

I think you would either need your own repository for pipeline config or point the dev one at your fork of this repo. So Pipeline -> custom config -> custom openshift/os -> profit

I think it would be better to add this to doc.

@c4rt0
Copy link
Contributor Author

c4rt0 commented Dec 20, 2023

I think you would either need your own repository for pipeline config or point the dev one at your fork of this repo. So Pipeline -> custom config -> custom openshift/os -> profit

@jschintag Since I failed to localize the custom config could you by any chance provide me a link to it?

@c4rt0 c4rt0 closed this Jan 19, 2024
@c4rt0 c4rt0 deleted the core-ign-failure branch January 23, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants