-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch coreos.ignition.failure err on 4.16 pipeline #1406
Conversation
After failing to reproduce `coreos.ignition.failure` locally I am removing it from denylist in order to catch errors in the pipeline. The goal of this PR is to allow it in RHCOS 4.16, catch the errors from the log and re-introduce `coreos.ignition.failure` to kola-denylist while working on solution. See: coreos/coreos-assembler#3670
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c4rt0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why not point the pipeline to your own branch of this repo instead, using the dev pipeline? |
Oh, that's a good suggestion. Let me investigate and find out how to do it. |
I think you would either need your own repository for pipeline config or point the dev one at your fork of this repo. |
@c4rt0: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think it would be better to add this to doc. |
@jschintag Since I failed to localize the |
After failing to reproduce
coreos.ignition.failure
locally I am removing it from denylist in order to catch errors in the pipeline. The goal of this PR is to allow it in RHCOS 4.16, catch the errors from the log and re-introducecoreos.ignition.failure
to kola-denylist while working on solution.See: coreos/coreos-assembler#3670