MCO-392: Re-enable ostree-container-inject-openshift-cvo-labels knob
#1457
Conversation
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
openshift-ci-robot
added
the
jira/valid-reference
|
@jlebon: This pull request references MCO-392 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold This needs to be coordinated with DTK, ART, and TRT. But let's make sure it's reviewed and ready to go once we're ready. |
openshift-ci
bot
added
do-not-merge/hold
|
/jira refresh |
|
@jlebon: This pull request references MCO-392 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, jmarrero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We're ready to do this! /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Wasn't sure if this was /label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
I'm going to force-merge this one. It's time-sensitive now that openshift/driver-toolkit#142 has merged. CI did pass previously here (but anyway the change here is not really tested by CI beyond the superficial level of cosa being able to add the labels to the oscontainer, which is trivial). /override ci/prow/rhcos-9-build-test-metal |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-9-build-test-metal, ci/prow/rhcos-9-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/images |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This was previously enabled (#1048, #1374) and then disabled again (#1084, #1393).
The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now:
openshift/release#49156
openshift/kubernetes#1805
So... third time's the charm!