NO-JIRA: ci/prow-entrypoint.sh: don't use grep -q at the end of pipeline
#1485
Conversation
Unlike `grep`, `grep -q` will exit 0 as soon as a match is found. This will cause whatever is writing into `grep` to hit `SIGPIPE`. And if it's not equipped to handle that signal, it'll be terminated and the overall if-condition will always fail due to `-o pipefail`. See also ostreedev/ostree#3203.
|
Should unblock coreos/coreos-assembler#3652. |
openshift-ci
bot
added
the
approved
|
/retitle NO-JIRA: ci/prow-entrypoint.sh: don't use |
openshift-ci
bot
changed the title
grep -q at the end of pipelinegrep -q at the end of pipeline
openshift-ci-robot
added
the
jira/valid-reference
|
@jlebon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, prestist, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Unlike
grep,grep -qwill exit 0 as soon as a match is found. This will cause whatever is writing intogrepto hitSIGPIPE. And if it's not equipped to handle that signal, it'll be terminated and the overall if-condition will always fail due to-o pipefail.See also ostreedev/ostree#3203.