MCO-280: extensions: Add container to serve repository with extensions

[jmarrero]

depends on: coreos/rpm-ostree#3562

This container will create a small service that will host the extensions rpms that we will be shipping. The idea is that this new container will be shipped alongside the machine-os and would provide a way for users layering extensions a way to do so without depending of connections outside of the cluster.

https://issues.redhat.com/browse/MCO-288

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[cgwalters]

Let's put all these files in an extensions/ subdirectory?

[jmarrero]

Let's put all these files in an extensions/ subdirectory?

That makes sense, I'll push that change today.

[cgwalters]

Cross-linking to https://issues.redhat.com/browse/MCO-288

I've been thinking about this one more, particularly in light of the discovery in coreos/coreos-assembler#2685 (comment)
Alongside that, a general problem we knew with Dockerfile approach here is that we're giving up on good "change detection".

I think combining those two facts pulls this back towards being something like cosa buildextend-extensions-container.

[jmarrero]

Cross-linking to https://issues.redhat.com/browse/MCO-288

I've been thinking about this one more, particularly in light of the discovery in coreos/coreos-assembler#2685 (comment) Alongside that, a general problem we knew with Dockerfile approach here is that we're giving up on good "change detection".

I think combining those two facts pulls this back towards being something like cosa buildextend-extensions-container.

Closing this PR in favor of the above.

[cgwalters]

Closing this PR in favor of the above.

Ideally though, we can reuse some or most of the code/approach here. We still need the webserver, etc. This was definitely not a lost effort!

I might have said we should keep the PR open as a reference and then rework it, but either way the code isn't lost.

Or alternatively...we could keep this all as is, but have a flow that updates meta.json after the "main" RHCOS build job. (Though, this gets into races unless we have a coordinator...needs some design)

[jmarrero]

I understand that, but does it still make sense to have most of that code here? I would imagine we would want to move a good chunk of this to cosa?

[cgwalters]

Joseph and I had a live chat about this. We're thinking we can:

• Keep the code here
• Add cosa buildextend-extensions-container that knows to build the Dockerfile in extensions/. This flow would either need to use the nested container stuff or (I think I like this better) do the build via KVM in the qemu image which we already have. Though this path will be implicitly testing podman.
• This build must substitute the base RHCOS in Dockerfile to pull the base ostree container, and not from a registry.
• This new extensions container needs to be appear in meta.json in the same way as the main one, see schema: Add entry for base-oscontainer coreos/coreos-assembler#2907. Probably change push-container to add cosa push-container --extensions or so?

[cgwalters]

Let's keep this open since I think we can likely reuse 95% of this work!

[jmarrero]

This depends on coreos/rpm-ostree#3819

[cgwalters]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,jmarrero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jmarrero: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.