-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(*): Vendor dependencies #177
bump(*): Vendor dependencies #177
Conversation
This ensures offline builds and ensures the project requirements are met.
Left a message in Slack, but do you have any context about this? I'm not averse to it but I'm not sure of what's driving this from a policy/business sense. |
The "policy/business sense" requires our product to be built offline. Being dependent on golang cache breaks the requirement. I've sent and org wide mail, but to cite a bit here:
The origin golang-1.13 builder image you use will be enforcing vendoring mode in openshift/release#6337
|
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeefy, meowfaceman, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This ensures offline builds and ensures the project requirements are met.
Also the project level golang builder is about to be switched to force vendoring mode.
/priority critical-urgent
/assign clcollins jeefy jeremyeder meowfaceman