Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27947: [release-4.15] Fix LGW ETP=Local on IPv6 #2028

Merged

Conversation

oribon
Copy link
Contributor

@oribon oribon commented Jan 25, 2024

clean cherry pick of c22ddd4 from main.
The service's node_switch LB was using the wrong address, breaking LGW IPv6 ETP=Local services.

The service's node_switch LB was using the wrong address, breaking LGW IPv6 ETP=Local services.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@oribon oribon requested a review from dcbw as a code owner January 25, 2024 08:12
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@oribon: This pull request references Jira Issue OCPBUGS-27947, which is invalid:

  • expected Jira Issue OCPBUGS-27947 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

clean cherry pick of c22ddd4 from main.
The service's node_switch LB was using the wrong address, breaking LGW IPv6 ETP=Local services.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oribon
Copy link
Contributor Author

oribon commented Jan 25, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@oribon: This pull request references Jira Issue OCPBUGS-27947, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27211 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-27211 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 25, 2024
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
clean pick
I wanted to ask where are the UTs for catching this :) at least we must test the config generation correct right? @oribon could you please open an upstream issue, or maybe @arghosh93 you have some time to work on adding UT coverage for this.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2024
@tssurya
Copy link
Contributor

tssurya commented Jan 29, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oribon, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssurya
Copy link
Contributor

tssurya commented Jan 29, 2024

/lgtm clean pick I wanted to ask where are the UTs for catching this :) at least we must test the config generation correct right? @oribon could you please open an upstream issue, or maybe @arghosh93 you have some time to work on adding UT coverage for this.

ah dangit there is already one: ovn-org/ovn-kubernetes#4081 and seems like I am working on that: ovn-org/ovn-kubernetes#4106 but still we are missing unit test coverage (@arghosh93 let's talk about this in our next 1:1)

@tssurya
Copy link
Contributor

tssurya commented Jan 29, 2024

/label backport-risk-assessed

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@tssurya: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Jan 29, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 29, 2024
@tssurya
Copy link
Contributor

tssurya commented Jan 30, 2024

/assign @anuragthehatter

@qiowang721
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 30, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2476c75 and 2 for PR HEAD 7a62709 in total

@tssurya
Copy link
Contributor

tssurya commented Jan 30, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@oribon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 7a62709 link false /test security
ci/prow/e2e-aws-ovn-kubevirt 7a62709 link false /test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oribon
Copy link
Contributor Author

oribon commented Jan 31, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit e61d7ef into openshift:release-4.15 Jan 31, 2024
28 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@oribon: Jira Issue OCPBUGS-27947: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27947 has been moved to the MODIFIED state.

In response to this:

clean cherry pick of c22ddd4 from main.
The service's node_switch LB was using the wrong address, breaking LGW IPv6 ETP=Local services.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202401312208.p0.ge61d7ef.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

@oribon
Copy link
Contributor Author

oribon commented Feb 1, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot

@oribon: new pull request created: #2042

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.