-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-27947: [release-4.15] Fix LGW ETP=Local on IPv6 #2028
OCPBUGS-27947: [release-4.15] Fix LGW ETP=Local on IPv6 #2028
Conversation
The service's node_switch LB was using the wrong address, breaking LGW IPv6 ETP=Local services. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@oribon: This pull request references Jira Issue OCPBUGS-27947, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@oribon: This pull request references Jira Issue OCPBUGS-27947, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
clean pick
I wanted to ask where are the UTs for catching this :) at least we must test the config generation correct right? @oribon could you please open an upstream issue, or maybe @arghosh93 you have some time to work on adding UT coverage for this.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oribon, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ah dangit there is already one: ovn-org/ovn-kubernetes#4081 and seems like I am working on that: ovn-org/ovn-kubernetes#4106 but still we are missing unit test coverage (@arghosh93 let's talk about this in our next 1:1) |
/label backport-risk-assessed |
@tssurya: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label backport-risk-assessed |
/assign @anuragthehatter |
/label cherry-pick-approved |
/retest-required |
@oribon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
e61d7ef
into
openshift:release-4.15
@oribon: Jira Issue OCPBUGS-27947: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27947 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202401312208.p0.ge61d7ef.assembly.stream for distgit ovn-kubernetes-base. |
/cherry-pick release-4.14 |
@oribon: new pull request created: #2042 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
clean cherry pick of c22ddd4 from main.
The service's node_switch LB was using the wrong address, breaking LGW IPv6 ETP=Local services.