Upgrade to operator-sdk v0.16.2 #100
Conversation
Followed upgrade guide at: https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/#v016x The reason I didn't go all the way to the latest 0.18.z is that after 0.16.z there were dependency conflicts that might best be solved by either updating dependencies in openshift/operator-custom-metrics, or by removing that as a dependency from this operator.
|
/cc @RiRa12621 ^since this was suggested at https://github.com/openshift/pagerduty-operator/pull/90/files#r448467970 |
|
/ok-to-test |
openshift-ci-robot
added
the
ok-to-test
|
Bump! Tests pass at least 🙂 |
|
/lgtm |
|
Discussed with the team and we agree this is a Good Thing. But not on a Friday. I'm on PTO next week but will approve and put on hold for deployment and testing in int/stage (side effect of merging this) next week. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grdryn, jewzaam, RiRa12621 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jewzaam We could just merge this as it's going int and stage only without the promotion to prod, shouldn't be a big deal even on Friday or weekend |
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Thanks @RiRa12621, I'll rebase my other PR now on top of the new master, which should make it much smaller. 👍 |
Followed upgrade guide at:
https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/#v016x
The reason I didn't go all the way to the latest 0.18.z is that after
0.16.z there were dependency conflicts that might best be solved by
either updating dependencies in openshift/operator-custom-metrics, or
by removing that as a dependency from this operator.