Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1870369: Fix gather bootstrap command #11120

Closed

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Aug 19, 2020

Fixes current setup by setting the GATHER_BOOTSTRAP_ARGS variable
which was missing before and now it will gather the bootstrap logs
successfully when the test is run.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Bugzilla bug 1870369, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870369: Fix gather bootstrap command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rna-afk
To complete the pull request process, please assign patrickdillon
You can assign the PR to them by writing /assign @patrickdillon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Bugzilla bug 1870369, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 19, 2020
@rna-afk rna-afk force-pushed the vsphere_upi_gather_bootstrap_fix branch 2 times, most recently from 675cc5a to b70f5a7 Compare August 21, 2020 16:24
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 21, 2020

/test pj-rehearse

1 similar comment
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 21, 2020

/test pj-rehearse

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 21, 2020

/retest

@rna-afk rna-afk force-pushed the vsphere_upi_gather_bootstrap_fix branch 5 times, most recently from 872b0c7 to 2133162 Compare August 25, 2020 14:50
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 25, 2020

/test pj-rehearse

5 similar comments
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 25, 2020

/test pj-rehearse

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 25, 2020

/test pj-rehearse

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 26, 2020

/test pj-rehearse

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 26, 2020

/test pj-rehearse

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 27, 2020

/test pj-rehearse

@rna-afk rna-afk force-pushed the vsphere_upi_gather_bootstrap_fix branch 2 times, most recently from 57cc7be to 30ec94a Compare August 27, 2020 14:48
@rna-afk rna-afk force-pushed the vsphere_upi_gather_bootstrap_fix branch 3 times, most recently from 8ed07b6 to e2a587e Compare August 27, 2020 19:00
Fixes current setup by setting the GATHER_BOOTSTRAP_ARGS variable
which was missing before and now it will gather the bootstrap logs
successfully when the test is run.
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 28, 2020

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rna-afk: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-vsphere-upi e2a587e link /test pj-rehearse
ci/prow/pj-rehearse e2a587e link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

@rna-afk since the images were moved to rhel8 and there is an issue with CSRs and the older cli I think you will need these:
openshift/installer#4098
#11397

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 28, 2020

Ah got it thanks! was wondering why the tests failed.

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 28, 2020

Alternate jq solution would be

val=$(echo $TERRAFORM_SHOW_DATA | jq -r '{IPs: [.values.root_module.child_modules[] | select(.address | startswith("module.ipam")) | .resources[] | select(.address | startswith("data.http.getip")) | .values.body']})
bootstrap_ip=$(echo $val | jq '.IPs[] | select(. | contains("bootstrap"))' | grep -Eo '([0-9]*\.){3}[0-9]*') 
echo $bootstrap_ip 

I thought the val part extraction looks long and unreadable compared to the grep answer. Let me know if this is a better solution.

@jcpowermac
Copy link
Contributor

jcpowermac commented Aug 31, 2020

@rna-afk
This is a significantly easier way of getting the ip address for the virtual machine. If vmware tools is not running the guest is not online far enough to grab data from it anyway

      declare "${hostname//-/_}_ip"="$(govc vm.ip -wait=1m -vm.ipath="$ipath" | awk -F',' '{print $1}')"

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2020
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 29, 2020
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Bugzilla bug 1870369. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1870369: Fix gather bootstrap command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants