Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: Bump golang image for the build. #1132

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

yifan-gu
Copy link
Contributor

@yifan-gu yifan-gu commented Jul 31, 2018

Bump golang from 1.9 to 1.10 for building the installer.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2018
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2018
@openshift-merge-robot openshift-merge-robot merged commit 1cefc59 into openshift:master Jul 31, 2018
@openshift-ci-robot
Copy link
Contributor

@yifan-gu: Updated the ci-operator-openshift-installer configmap using the following files:

  • key master.json using file ci-operator/config/openshift/installer/master.json

In response to this:

Bump golang from 1.9 to 1.10 for building the installer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yifan-gu yifan-gu deleted the bump_golang branch July 31, 2018 23:33
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Using OPENSHIFT_VERSION=4.5.0 results in failure of
the auth template generation because it take wrong path
as the condition only checks for 4.5 only. Trim the version
if it is of format x.y.z before checking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants