openshift-installer-presubmits: Separate sequence entry for --action_env #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid [1]: sh: 0: Can't open ./hack/test-bazel-build-tarball.sh --action_env=HOME=/tmp [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/125/ci-pull-openshift-installer-bazel-build-tarball/18/build-log.txt
openshift-ci-robot
added
the
size/XS
|
/lgtm |
|
@wking: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
In recent (2.2.1 tested) podman versions, this file ends up unreadable as $USER e.g in utils.sh $ sudo podman login --authfile /tmp/test.json ... Login Succeeded! -rw-------. 1 root root 107 Feb 17 12:00 /tmp/test.json In future we should probably test removing all the `sudo podman` calls to use rootless mode, but since that has historically been buggy, this is a lower risk interim fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid:
This PR fixes a typo from #1185.
/assign @smarterclayton.