Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/templates: Remove TEST_SUITE(_SERIAL) #1261

Merged
merged 1 commit into from
Aug 31, 2018
Merged

ci-operator/templates: Remove TEST_SUITE(_SERIAL) #1261

merged 1 commit into from
Aug 31, 2018

Conversation

wking
Copy link
Member

@wking wking commented Aug 22, 2018

The last consumer was removed in 7ea9239 (#874). And the origin extended.test deprecated -suite in favor of focus in openshift/origin@83d9db89 (openshift/origin#15915).

@wking
ci-operator/templates: Remove TEST_SUITE(_SERIAL)
8561f18 
The last consumer was removed in 7ea9239 (Change job focus for
image-registry e2e, 2018-05-21, openshift#874).  And the origin extended.test
deprecated -suite in favor of focus in openshift/origin@83d9db89 (Make
focus and skip a lot easier to use in extended tests, 2017-08-22,
openshift/origin#15915).
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2018
@wking
Copy link
Member Author

wking commented Aug 23, 2018

/assign @smarterclayton

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2018
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2018
@wking
Copy link
Member Author

wking commented Aug 31, 2018

Tide seems to be hung up:

Not mergeable. Job ci/prow/ordered-prow-config has not succeeded.

I'm not sure what's going on with that, since I don't see that job in GitHub's check list and Tide sounds happy here. Maybe it's just that the job is new since this PR was submitted. See if kicking that job will help unstick us:

/test ordered-prow-config

@wking
Copy link
Member Author

wking commented Aug 31, 2018

Or I'll just run all the tests again :p.

/test all

@openshift-merge-robot openshift-merge-robot merged commit 6d34ec1 into openshift:master Aug 31, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 4 configmaps:

  • prow-job-cluster-launch-src configmap using the following files:
    • key cluster-launch-src.yaml using file ci-operator/templates/cluster-launch-src.yaml
  • prow-job-cluster-launch-e2e-gmontero-testing configmap using the following files:
    • key cluster-launch-e2e-gmontero-testing.yaml using file ci-operator/templates/cluster-launch-e2e-gmontero-testing.yaml
  • prow-job-cluster-launch-e2e configmap using the following files:
    • key cluster-launch-e2e.yaml using file ci-operator/templates/cluster-launch-e2e.yaml
  • prow-job-cluster-launch-installer-e2e configmap using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/cluster-launch-installer-e2e.yaml

In response to this:

The last consumer was removed in 7ea9239 (#874). And the origin extended.test deprecated -suite in favor of focus in openshift/origin@83d9db89 (openshift/origin#15915).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the remove-extended.test-suite branch August 31, 2018 19:10
@wking wking mentioned this pull request Sep 16, 2018
Merged
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@ardaguclu
Increase WORKER_DISK to 30 (openshift#1261)
6b95ad3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @smarterclayton @openshift-ci-robot @openshift-merge-robot