-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift-installer-presubmits: Normalize job names #1354
openshift-installer-presubmits: Normalize job names #1354
Conversation
You'll lose history but that shouldn't be an issue. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wking: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: FYI, that's the format used by the configuration generator: https://github.com/openshift/ci-operator-prowgen/blob/master/GENERATOR.md |
Like 81a9e69 (openshift-installer-presubmits: Normalize job names, 2018-09-04, openshift#1354), but for the new smoke-test job from 199f2e0 (openshift/install e2e-aws add run smoke tests, 2018-08-28, openshift#1317).
) This reverts commit fc2ff40.
pull-ci-*
is much more popular thanci-pull-*
:And
*-openshift-installer-*
fits with the repo name and this file path more closely than*-origin-installer-*
.