Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-installer-presubmits: Normalize job names #1354

Merged

Conversation

wking
Copy link
Member

@wking wking commented Sep 4, 2018

pull-ci-* is much more popular than ci-pull-*:

$ git describe --always --abbrev=10 origin/master
6fb4a70f74
$ git grep pull-ci 6fb4a70f74 | wc -l
133
$ git grep ci-pull 6fb4a70f74 | wc -l
7

And *-openshift-installer-* fits with the repo name and this file path more closely than *-origin-installer-*.

pull-ci-* is much more popular than ci-pull-*:

  $ git describe --always --abbrev=10 origin/master
  6fb4a70
  $ git grep pull-ci 6fb4a70 | wc -l
  133
  $ git grep ci-pull 6fb4a70 | wc -l
  7

And *-openshift-installer-* fits with the repo name and this file path
more closely than *-origin-installer-*.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2018
@smarterclayton
Copy link
Contributor

You'll lose history but that shouldn't be an issue.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 56c0e35 into openshift:master Sep 4, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the job-config configmap using the following files:

  • key openshift-installer-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml

In response to this:

pull-ci-* is much more popular than ci-pull-*:

$ git describe --always --abbrev=10 origin/master
6fb4a70f74
$ git grep pull-ci 6fb4a70f74 | wc -l
133
$ git grep ci-pull 6fb4a70f74 | wc -l
7

And *-openshift-installer-* fits with the repo name and this file path more closely than *-origin-installer-*.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the installer-job-name-cleanup branch September 4, 2018 23:12
@bbguimaraes
Copy link
Contributor

@wking: FYI, that's the format used by the configuration generator:

https://github.com/openshift/ci-operator-prowgen/blob/master/GENERATOR.md

wking added a commit to wking/openshift-release that referenced this pull request Sep 10, 2018
Like 81a9e69 (openshift-installer-presubmits: Normalize job names,
2018-09-04, openshift#1354), but for the new smoke-test job from 199f2e0
(openshift/install e2e-aws add run smoke tests, 2018-08-28, openshift#1317).
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants