Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-operator/templates/cluster-launch-installer-e2e*: Destroy with --continue-on-error #1542

Commits on Sep 18, 2018

  1. ci-operator/templates/cluster-launch-installer-e2e*: Destroy with --c…

    …ontinue-on-error
    
    Taking advantage of openshift/installer@23915f2e (installer/*: Add
    --continue-on-error to destroy workflow, 2018-09-16,
    openshift/installer#252) so we can reap at least most of our resources
    even if the cluster doesn't come up enough for the machine API
    operator to be able to destroy workers.  With various stages of
    cluster health:
    
    1. Cluster never comes up at all.
    2. Cluster healthy enough to create workers.
    3. Cluster healthy enough to destroy workers.
    
    we're only worried about leakage in the space between 2 and 3.
    Hopefully there isn't any space there, but without this commit we're
    currently leaking resources from 1 as well.
    
    The two-part destroy attempts are originally from 51df634 (Support an
    aws installer CI job, 2018-06-07, openshift#928), although there's not much to
    motivate them there.  With --continue-on-error destruction, we're
    already trying pretty hard to clean everything up.  So excepting brief
    network hiccups and such, I think a single pass is sufficient.  And
    we'll want a better backstop to catch any resources that leak through
    (e.g. orphaned workers), so I'm dropping the retry here.
    wking committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    8444b7d View commit details
    Browse the repository at this point in the history