gather/aws-console: Make log gathering non-fatal #17735
Conversation
Something in our console content is either UTF-8 and this is expecting ASCII, or is invalid UTF-8. To unblock RHCOS promotion jobs, make gathering the console non-fatal.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@cgwalters: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In recent CI, we have failed console gathers like [1]: Gathering console logs for i-026ba0637214cd027 'ascii' codec can't encode character '\u2026' in position 14093: ordinal not in range(128) Failed to gather console logs This is descended from d060927 (gather/aws-console: Make log gathering non-fatal, 2021-04-14, openshift#17735). But we want to gather these logs, not silently fail to gather the logs. This commit restores our old "fail the step when we fail to gather" behavior, and sets PYTHONIOENCODING [2] to ask for UTF-8 instead of ASCII output. [1]: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-[…]e2e-aws-serial/gather-aws-console/build-log.txt [2]: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONIOENCODING
Something in our console content is either UTF-8 and this is
expecting ASCII, or is invalid UTF-8. To unblock RHCOS
promotion jobs, make gathering the console non-fatal.