Apply the needs-upstream label for PRs with vendor changes #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
openshift-ci-robot
requested review from
deads2k,
0xmichalis and
smarterclayton
openshift-ci-robot
added
the
size/XS
|
@soltysh can you explain how you would use this for blocking upstream pulls during a kube rebase? |
|
We can expand the submit-queue's negative label list to include it (think the opposite of the |
|
We will get it for free with /lgtm |
0xmichalis
approved these changes
Oct 4, 2017
|
It still sucks that the queue will need to restart for the label change. |
|
What I wanted to do, which would not be webhook based, was use a graphql query and commenter bot to just add /hold on to the prs... |
|
SGTM. We should run something similar when we add new blocking presubmits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/cc @deads2k @Kargakis @smarterclayton