Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-operator/templates/openshift: Drop --log-level=debug #2453

Merged

Conversation

wking
Copy link
Member

@wking wking commented Dec 19, 2018

This makes it easier for folks who are less familiar with the debug logs to find the actual error message. For folks who do need access to the debug logs, we still have those in the recovered artifacts since openshift/installer@06c5fd36 (openshift/installer#689), e.g. here.

Generated with:

$ sed -i 's/--log-level.debug //' $(git grep -l -- '--log-level.debug')

/assign @smarterclayton

This makes it easier for folks who are less familiar with the debug
logs to find the actual error message.  For folks who *do* need access
to the debug logs, we still have those in the recovered artifacts
since openshift/installer@06c5fd36 (openshift-install: log debug
output to file, 2018-11-15, openshift/installer#689).

Generated with:

  $ sed -i 's/--log-level.debug //' $(git grep -l -- '--log-level.debug')
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2018
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2018
@openshift-merge-robot openshift-merge-robot merged commit 08dea32 into openshift:master Dec 19, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 3 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-src configmap using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-e2e-40 configmap using the following files:
    • key cluster-launch-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-launch-e2e-40.yaml

In response to this:

This makes it easier for folks who are less familiar with the debug logs to find the actual error message. For folks who do need access to the debug logs, we still have those in the recovered artifacts since openshift/installer@06c5fd36 (openshift/installer#689), e.g. here.

Generated with:

$ sed -i 's/--log-level.debug //' $(git grep -l -- '--log-level.debug')

/assign @smarterclayton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the installer-default-log-level branch January 2, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants