Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYOR 4.0 scaleup: don't copy install config #2884

Merged
merged 1 commit into from
Feb 20, 2019
Merged

BYOR 4.0 scaleup: don't copy install config #2884

merged 1 commit into from
Feb 20, 2019

Conversation

vrutkovs
Copy link
Member

Its no longer needed as all necessary information (MCS endpoint) can be
extracted from the cluster (implemented in openshift/openshift-ansible#11203)

@vrutkovs
BYOR 4.0 scaleup: don't copy install config
a644f75 
Its no longer needed as all necessary information (MCS endpoint) can be 
extracted from the cluster
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@vrutkovs
Copy link
Member Author

/hold
until openshift-ansible PR is merged

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 18, 2019
@vrutkovs
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
mtnbikenc
mtnbikenc approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 47e6602 into openshift:master Feb 20, 2019
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Updated the following 2 configmaps:

  • prow-job-cluster-scaleup-e2e-40 configmap in namespace ci using the following files:
    • key cluster-scaleup-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e-40.yaml
  • prow-job-cluster-scaleup-e2e-40 configmap in namespace ci-stg using the following files:
    • key cluster-scaleup-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e-40.yaml

In response to this:

Its no longer needed as all necessary information (MCS endpoint) can be
extracted from the cluster (implemented in openshift/openshift-ansible#11203)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Feb 26, 2019
Merged
@vrutkovs vrutkovs deleted the byor-40-install-config branch January 27, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@mtnbikenc mtnbikenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrutkovs @openshift-ci-robot @mtnbikenc @openshift-merge-robot