Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one of the new style upgrade tests to ci-operator #3030

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Add one of the new style upgrade tests to ci-operator #3030

merged 1 commit into from
Mar 10, 2019

Conversation

smarterclayton
Copy link
Contributor

Requires changes to ci-operator-prowgen and openshift/ci-operator#288
first but shows what the jobs will look like.

@smarterclayton smarterclayton mentioned this pull request Mar 7, 2019
Merged
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 7, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2019
@smarterclayton
Add new style upgrade test to CVO and origin
55e0e36 
* Update release periodics to use the new parameters in ci-operator.
* Add the upgrade release periodic for use with ci-operator, mark optional
* Fix some misplaced roles
* Add a promotion periodic for machine-os-content from rhcos/maipo:latest to ocp/4.0

Requires changes to ci-operator-prowgen and openshift/ci-operator#288
first but shows what the jobs will look like.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2019
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/origin/master/unit 55e0e36 link /test pj-rehearse
ci/prow/pj-rehearse 55e0e36 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9a4829d into openshift:master Mar 10, 2019
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-version-operator-master.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-cluster-version-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-master-presubmits.yaml
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • job-config-misc configmap in namespace ci using the following files:
    • key openshift-release-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-periodics.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-cluster-version-operator-master.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml

In response to this:

Requires changes to ci-operator-prowgen and openshift/ci-operator#288
first but shows what the jobs will look like.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking
wking reviewed Mar 11, 2019
View reviewed changes
ci-operator/jobs/openshift/release/openshift-release-periodics.yaml
- args:
- --artifact-dir=$(ARTIFACTS)
- --secret-dir=/usr/local/e2e-aws-cluster-profile
- --template=/usr/local/e2e-aws
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installer is still hitting the builds.json API to decide which RHCOS build to use for the AMIs, so I dunno if this promotion test is actually protecting us from boot-image issues at the moment. For example:

$ curl -s https://storage.googleapis.com/origin-ci-test/logs/release-promote-openshift-machine-os-content-e2e-aws-4.0/10/artifacts/e2e-aws/installer/.openshift_install.log | grep RHCOS
time="2019-03-11T03:28:56Z" level=debug msg="Fetching RHCOS builds from \"https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/builds.json\""
time="2019-03-11T03:28:57Z" level=debug msg="Fetching RHCOS metadata from \"https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/400.7.20190306.0/meta.json\""

We'll also need something like the in-flight openshift/installer#1286 and maybe openshift/origin#21998 for that.

I guess this promotion test is currently giving us gate-protection for the OSContainer image, protecting us from post-pivot changes?

@smarterclayton smarterclayton deleted the upgrade_jobx branch April 24, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@staebler staebler Awaiting requested review from staebler

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smarterclayton @openshift-ci-robot @wking @openshift-merge-robot