Run vsphere UPI tests for installer repo #3305

vrutkovs · 2019-03-29T19:15:00Z

This adds a new vsphere profile and a template for UPI installs

~~cluster-secrets-vsphere secret needs to be uploaded in ci namespace - it should be similar to cluster-secrets-vsphere configmap in ci-stg namespace.~~

Known issues:

Requires IPAM changes to be merged to avoid setting compute_ips manually
upi/vsphere: multiple terraform updates installer#1518
Third-party service is used (sprunge.us) is used to upload boostrap.ign
Teardown breaks with Error loading modules: module resource_pool: open .terraform/modules/e4930eeba1a55c7c704743ec141be411: no such file or directory error
upi-installer image fails to be built, as repos can't find epel-release and thus fail when jq (and awscli) are being installed. This is not critical for vsphere
No cloudprovider support (upi/vsphere: add vsphere to cloudproviderconfig installer#1516)
Secret needs to be updated to include ipam_password
Rework config when types/vsphere: simplify vsphere platform installer#1591 is merged
Store user/password in a secret and mount it in setup container. Installer should be able to read it

staebler

Looks good.

cluster/ci/config/prow/plugins.yaml

smarterclayton · 2019-03-30T22:07:43Z

The job name should be e2e-vsphere, please remove -upi- from it.

Makefile

vrutkovs · 2019-04-04T08:16:17Z

/test pj-rehearse

vrutkovs · 2019-04-04T10:23:38Z

/hold

Few more details need to be sorted out

vrutkovs · 2019-04-04T10:59:07Z

/test pj-rehearse

vrutkovs · 2019-04-09T15:50:44Z

/test pj-rehearse

dav1x · 2019-04-09T16:46:02Z

ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml

@@ -391,6 +391,8 @@ objects:
        cat > /tmp/tf/terraform.tfvars <<-EOF
          ipam = "139.178.89.254"

+          machine_cidr = "139.178.89.192/26"


This particular CIDR corresponds to the vcsa.vmware.devcluster.openshift.com.
The ci environment vcsa-ci.vmware.devcluster.openshift.com uses: "139.178.73.0/26".
The qe environment vcsa-qe.vmware.devcluster.openshift.com uses: "139.178.76.0/26"

The vcenter_server environment should correspond to those CIDR.

Ah, thanks! Eventually this will be a part of vsphere secret anyway

vrutkovs · 2019-04-14T15:42:52Z


Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]
[Conformance][Area:Networking][Feature:Router] The HAProxy router should expose a health check on the metrics port [Suite:openshift/conformance/parallel/minimal]
[Conformance][Area:Networking][Feature:Router] The HAProxy router should expose the profiling endpoints [Suite:openshift/conformance/parallel/minimal]
[Conformance][Area:Networking][Feature:Router] The HAProxy router should respond with 503 to unrecognized hosts [Suite:openshift/conformance/parallel/minimal]
[Conformance][Area:Networking][Feature:Router] The HAProxy router should serve routes that were created from an ingress [Suite:openshift/conformance/parallel/minimal]
[Conformance][Area:Networking][Feature:Router] The HAProxy router should set Forwarded headers appropriately [Suite:openshift/conformance/parallel/minimal]
[Conformance][Area:Networking][Feature:Router] The HAProxy router should support reencrypt to services backed by a serving certificate automatically [Suite:openshift/conformance/parallel/minimal]
[sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] should adopt matching orphans and release non-matching pods [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] should not deadlock when a pod's predecessor fails [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] should perform rolling updates and roll backs of template modifications with PVCs [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] should provide basic identity [Suite:openshift/conformance/parallel] [Suite:k8s]

vrutkovs · 2019-04-15T09:49:09Z

vSphere PVCs won't accept storage: "1" in PVC declaration, these need storage: "1Gi" - this fails StatefulSet tests. Filed https://bugzilla.redhat.com/show_bug.cgi?id=1699820

vrutkovs · 2019-04-15T10:12:19Z

/hold

Pushed a commit which won't start tests so that Network Edge and Storage teams could have a look

vrutkovs · 2019-04-15T14:14:41Z

/hold cancel

All required changes are commited.

HAProxy tests start a new router, which is not possible in vSphere, as it already runs two routers on host network. These tests are now being skipped

vrutkovs · 2019-04-15T14:24:13Z

/test pj-rehearse

no such image transient error

abhinavdahiya · 2019-04-15T15:11:44Z

/hold cancel

All required changes are commited.

HAProxy tests start a new router, which is not possible in vSphere, as it already runs two routers on host network. These tests are now being skipped

Can you include the PR that makes that change?

vrutkovs · 2019-04-15T15:13:47Z

/hold cancel
All required changes are commited.
HAProxy tests start a new router, which is not possible in vSphere, as it already runs two routers on host network. These tests are now being skipped

Can you include the PR that makes that change?

TEST_SKIP is being set in 4367c6d

vrutkovs · 2019-04-15T15:13:57Z

/test pj-rehearse

vrutkovs · 2019-04-16T14:29:03Z

/test pj-rehearse

vrutkovs · 2019-04-16T15:33:27Z

/test pj-rehearse

stevekuznetsov · 2019-04-16T16:43:34Z

/lgtm
/approve
/hold cancel

openshift-ci-robot · 2019-04-16T16:43:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, stevekuznetsov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [petr-muller,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-04-16T16:47:36Z

@vrutkovs: Updated the following 4 configmaps:

plugins configmap in namespace ci using the following files:
- key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
ci-operator-master-configs configmap in namespace ci using the following files:
- key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
ci-operator-master-configs configmap in namespace ci-stg using the following files:
- key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
job-config-master configmap in namespace ci using the following files:
- key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml

In response to this:

This adds a new vsphere profile and a template for UPI installs

~~cluster-secrets-vsphere secret needs to be uploaded in ci namespace - it should be similar to cluster-secrets-vsphere configmap in ci-stg namespace.~~

Known issues:

Requires IPAM changes to be merged to avoid setting compute_ips manually
upi/vsphere: multiple terraform updates installer#1518

Third-party service is used (sprunge.us) is used to upload boostrap.ign

Teardown breaks with Error loading modules: module resource_pool: open .terraform/modules/e4930eeba1a55c7c704743ec141be411: no such file or directory error

upi-installer image fails to be built, as repos can't find epel-release and thus fail when jq (and awscli) are being installed. This is not critical for vsphere

No cloudprovider support (upi/vsphere: add vsphere to cloudproviderconfig installer#1516)

Secret needs to be updated to include ipam_password

Rework config when types/vsphere: simplify vsphere platform installer#1591 is merged

Store user/password in a secret and mount it in setup container. Installer should be able to read it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-04-16T17:31:15Z

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-vsphere	`e95bad6`	link	`/test pj-rehearse`
ci/prow/pj-rehearse	`e95bad6`	link	`/test pj-rehearse`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 29, 2019

openshift-ci-robot requested review from aaronlevy and crawford March 29, 2019 19:15

staebler reviewed Mar 29, 2019

View reviewed changes

cluster/ci/config/prow/plugins.yaml Outdated Show resolved Hide resolved

vrutkovs force-pushed the installer-vmware branch 2 times, most recently from 9da5b06 to 1dd47cc Compare March 29, 2019 22:02

vrutkovs force-pushed the installer-vmware branch from 64e2086 to ade587f Compare April 1, 2019 11:46

stevekuznetsov reviewed Apr 1, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

stevekuznetsov reviewed Apr 4, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2019

vrutkovs force-pushed the installer-vmware branch from 8f72857 to 93d99d5 Compare April 8, 2019 08:27

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2019

vrutkovs force-pushed the installer-vmware branch 2 times, most recently from ca7838b to 87680bb Compare April 8, 2019 08:56

vrutkovs mentioned this pull request Apr 9, 2019

DPTP-376: Rename vsphere credentials #3397

Merged

vrutkovs force-pushed the installer-vmware branch 2 times, most recently from d3ae3d8 to 78da020 Compare April 9, 2019 15:42

vrutkovs force-pushed the installer-vmware branch from 78da020 to c72caf6 Compare April 9, 2019 15:51

dav1x reviewed Apr 9, 2019

View reviewed changes

vrutkovs force-pushed the installer-vmware branch 5 times, most recently from d69410a to b3ff9d1 Compare April 9, 2019 19:32

vrutkovs force-pushed the installer-vmware branch from 014d9cd to 7d88114 Compare April 14, 2019 09:26

vrutkovs force-pushed the installer-vmware branch from 7d88114 to 94949e8 Compare April 15, 2019 08:36

vrutkovs force-pushed the installer-vmware branch from 94949e8 to 1646d2a Compare April 15, 2019 10:11

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019

vrutkovs added 2 commits April 15, 2019 13:19

Run vsphere test

4e27dcc

Create a template for UPI testing

e95bad6

vrutkovs force-pushed the installer-vmware branch from 1646d2a to 4367c6d Compare April 15, 2019 14:02

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019

vrutkovs force-pushed the installer-vmware branch 5 times, most recently from 3d88ffe to e95bad6 Compare April 16, 2019 13:57

openshift-ci-robot assigned stevekuznetsov Apr 16, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019

openshift-merge-robot merged commit 9868168 into openshift:master Apr 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run vsphere UPI tests for installer repo #3305

Run vsphere UPI tests for installer repo #3305

vrutkovs commented Mar 29, 2019 •

edited

Loading

staebler left a comment

smarterclayton commented Mar 30, 2019

vrutkovs commented Apr 4, 2019

vrutkovs commented Apr 4, 2019

vrutkovs commented Apr 4, 2019

vrutkovs commented Apr 9, 2019

dav1x Apr 9, 2019

vrutkovs Apr 9, 2019

vrutkovs commented Apr 14, 2019

vrutkovs commented Apr 15, 2019 •

edited

Loading

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

abhinavdahiya commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 16, 2019

vrutkovs commented Apr 16, 2019

stevekuznetsov commented Apr 16, 2019

openshift-ci-robot commented Apr 16, 2019

openshift-ci-robot commented Apr 16, 2019

openshift-ci-robot commented Apr 16, 2019

Run vsphere UPI tests for installer repo #3305

Run vsphere UPI tests for installer repo #3305

Conversation

vrutkovs commented Mar 29, 2019 • edited Loading

staebler left a comment

Choose a reason for hiding this comment

smarterclayton commented Mar 30, 2019

vrutkovs commented Apr 4, 2019

vrutkovs commented Apr 4, 2019

vrutkovs commented Apr 4, 2019

vrutkovs commented Apr 9, 2019

dav1x Apr 9, 2019

Choose a reason for hiding this comment

vrutkovs Apr 9, 2019

Choose a reason for hiding this comment

vrutkovs commented Apr 14, 2019

vrutkovs commented Apr 15, 2019 • edited Loading

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

abhinavdahiya commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 15, 2019

vrutkovs commented Apr 16, 2019

vrutkovs commented Apr 16, 2019

stevekuznetsov commented Apr 16, 2019

openshift-ci-robot commented Apr 16, 2019

openshift-ci-robot commented Apr 16, 2019

openshift-ci-robot commented Apr 16, 2019

vrutkovs commented Mar 29, 2019 •

edited

Loading

vrutkovs commented Apr 15, 2019 •

edited

Loading